Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PUT /rooms/$room_id/send/m.room.message/$txn_id tests #321

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Add PUT /rooms/$room_id/send/m.room.message/$txn_id tests #321

merged 2 commits into from
Nov 11, 2016

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Nov 11, 2016

  • A general one (we only had one for POST)
  • One to test idempotency of PUTs

Also moved the proves statement to the PUT endpoint rather than the POST endpoint as the send message helper function uses the PUT form.

@kegsay
Add PUT /rooms/$room_id/send/m.room.message/$txn_id tests
f1e4ffb 
- A general one (we only had one for POST)
- One to test idempotency of PUTs
@kegsay
Add idempotency PUT test
6260952
@kegsay kegsay mentioned this pull request Nov 11, 2016
Merged
@leonerd
Copy link
Contributor

leonerd commented Nov 11, 2016

LGTM

@kegsay kegsay merged commit 16d904e into develop Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@leonerd leonerd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kegsay @leonerd