-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reliability tests for direct-to-device messaging #295
Conversation
|
||
push our @EXPORT, qw( matrix_send_to_device_message ); | ||
|
||
sub matrix_send_to_device_message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bold choice of name there. Maybe send_message_to_device
; or perhaps is the "message" part implied? Could it be just send_to_device
?
Having got to the end I now see that to device message is in fact a compound noun, not part of the verb structure. I wonder if this code would be a bit more readable were these renamed to something else, perhaps a "device-directed message" or similar? If that name sounds a bit long, I don't think it would be unreasonable to document/specify these at the protocol level and introduce the initialism DDM to refer to it; then we can name functions
|
@leonerd I've called it a
|
LGTM |
Adds tests for matrix-org/synapse#1046