Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for rejecting invites #25

Closed
wants to merge 2 commits into from
Closed

Conversation

illicitonion
Copy link
Contributor

No description provided.

my $other_local_user_preparer = local_user_preparer();

test "Invited user can reject invite",
requires => [ do { my $creator = local_user_preparer(); $creator, local_user_preparer(), inviteonly_room_preparer( creator => $creator ) } ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more linefeeds would help here. Maybe

requires => [ local_user_preparer(),
   do {
      my $creator = local_user_preparer();
      $creator, inviteonly_room_preparer( creator => $creator );
   } ],

by pulling the (unrelated) invitee up front. You'll have to swap the order of $creator and $invitee to the invoked function below then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@leonerd
Copy link
Contributor

leonerd commented Oct 19, 2015

LGTM, asides the linebreak formatting.

Given the test failure, I suspect it needs a merge on synapse before this itself, yes?

@illicitonion
Copy link
Contributor Author

Yep, blocked on matrix-org/synapse#317

@illicitonion illicitonion deleted the daniel/rejectinvites branch October 20, 2015 13:06
@illicitonion
Copy link
Contributor Author

Manually merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants