-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow HSes to omit device display names #1307
Conversation
Hopefully gets matrix-org/synapse#10015 over the line.
# and they're considered optional in the GET /user/devices/{userId} response. | ||
# So accept either a match or a lack of key. | ||
my $device_display_name = $alice_device_keys->{"unsigned"}->{"device_display_name"}; | ||
$device_display_name = undef or $device_display_name = "test display name" or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wtf was I smoking---this =
is assinging, not testing (==
?)
I'm going to have to read perl docs now, aren't I?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My perl is as good as yours but it's green so sure?
I tried to convince myself this was sane as follows:
|
Hopefully gets matrix-org/synapse#10015 over the line.
I don't speak perl and it's not easy to test this change against that PR because it comes from a fork.
I suggest we merge this if CI is green and move on with our lives.