Test support for inviting 3pids in /createRoom #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| my $invite_info = { | ||
| medium => "email", | ||
| address => $invitee_email, | ||
| id_server => $id_server->name, |
There was a problem hiding this comment.
Please align the three '=>'s
| id_server => $id_server->name, | ||
| }; | ||
| matrix_create_room( $inviter, invite_3pid => [ $invite_info ] ) | ||
| ->then( sub { |
There was a problem hiding this comment.
It would avoid the excessive indentation here, to end this then block and start another; by doing
matrix_create_room( ... );
})->then( sub {
( $room_id ) = @_;
|
Aside from the indentation/reflow (which can be fixed up later) this LGTM. |
erikjohnston
force-pushed
the
erikj/create_room_3pid_invite
branch
from
36d0307 to
5cbc8c0
Compare
erikjohnston
added a commit
that referenced
this pull request
Jan 5, 2016
Test support for inviting 3pids in /createRoom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix-org/matrix-spec-proposals#247
matrix-org/synapse#460