Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent GHA workflow failing for Dendrite #1210

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Prevent GHA workflow failing for Dendrite #1210

merged 2 commits into from
Mar 11, 2022

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Mar 10, 2022 •
edited
Loading

Sytest appears to fail against Dendrite, so let's disable it for now.

richvdh added 2 commits March 10, 2022 16:04
@richvdh
Prevent GHA workflow failing for Dendrite
1bd5811 
Sytest appears to fail against Dendrite, so let's not fail the whole workflow.
@richvdh
disable dendrite altogether
ea298e7
@richvdh richvdh marked this pull request as ready for review March 10, 2022 16:56
@richvdh richvdh requested a review from a team as a code owner March 10, 2022 16:56
clokep
clokep approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect @kegsay's review is enough, but if CI is happy and Dendrite folks are happy than I'm happy. Have a ✅ !

@richvdh richvdh merged commit 2780655 into develop Mar 11, 2022
@richvdh richvdh deleted the rav/no_fail_dendrite branch March 11, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegsay kegsay kegsay approved these changes

@clokep clokep clokep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richvdh @clokep @kegsay