Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /v3 endpoints #1200

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Use /v3 endpoints #1200

merged 3 commits into from
Mar 2, 2022

Conversation

neilalexander
Copy link
Contributor

@neilalexander neilalexander commented Mar 2, 2022

This PR moves client API calls onto /v3 endpoints instead of /r0, /unstable etc.

@neilalexander neilalexander marked this pull request as ready for review March 2, 2022 11:44
@neilalexander neilalexander requested a review from a team as a code owner March 2, 2022 11:44
@neilalexander neilalexander requested a review from richvdh March 2, 2022 12:48
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -1284,10 +1284,10 @@ sub generate_haproxy_map
# haproxy. Also, the routing for GET requests below takes precedence over
# these routes.
my $haproxy_map = <<'EOCONFIG';
^/_matrix/client/(v2_alpha|r0)/sync$ synchrotron
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this stuff really needs to match what's at https://matrix-org.github.io/synapse/develop/workers.html, but keeping them in sync is a bigger topic (matrix-org/synapse#12139). This is fine for now, though I would have taken the opportunity to push v2_alpha and api/v1 into a burning pit.

@neilalexander neilalexander merged commit 5f4c26a into develop Mar 2, 2022
@neilalexander neilalexander deleted the neilalexander/v3 branch March 2, 2022 17:35
neilalexander added a commit to matrix-org/dendrite that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants