-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a valid formatted key to test upload of a key #1111
Conversation
The algorithms, keys and signatures parameters are required Signed-off-by: Kurt Roeckx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we merge this? Oh, Synapse is failing - @matrix-org/synapse-core thoughts?
well, hence matrix-org/synapse#10554 I guess. We could add the new test to the synapse blacklist 🤷 |
That feels like a reasonable thing to do, given we do the same on the dendrite side for edge cases like this. |
Synapse PR to add this to the blacklist: matrix-org/synapse#11270 |
Synapse should now have blacklisted this test, so if we merge in |
Is the dendrite faulures expected? |
I think we have seen |
It'd be good to try and hunt that down at some point, failing CI is sad, etc. |
The algorithms, keys and signatures parameters are required
Signed-off-by: Kurt Roeckx [email protected]