Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a valid formatted key to test upload of a key #1111

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

kroeckx
Copy link
Contributor

@kroeckx kroeckx commented Aug 7, 2021

The algorithms, keys and signatures parameters are required

Signed-off-by: Kurt Roeckx [email protected]

The algorithms, keys and signatures parameters are required

Signed-off-by: Kurt Roeckx <[email protected]>
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge this? Oh, Synapse is failing - @matrix-org/synapse-core thoughts?

@DMRobertson DMRobertson requested a review from a team November 2, 2021 10:46
@richvdh
Copy link
Member

richvdh commented Nov 2, 2021

well, hence matrix-org/synapse#10554 I guess. We could add the new test to the synapse blacklist 🤷

@kegsay
Copy link
Member

kegsay commented Nov 2, 2021

That feels like a reasonable thing to do, given we do the same on the dendrite side for edge cases like this.

@erikjohnston
Copy link
Member

Synapse PR to add this to the blacklist: matrix-org/synapse#11270

@erikjohnston
Copy link
Member

Synapse should now have blacklisted this test, so if we merge in develop CI should pass

@erikjohnston
Copy link
Member

Is the dendrite faulures expected?

@neilalexander
Copy link
Contributor

I think we have seen Inbound federation can query room alias directory failing on the Dendrite side sometimes, so I wouldn't worry too much about that.

@erikjohnston
Copy link
Member

I think we have seen Inbound federation can query room alias directory failing on the Dendrite side sometimes, so I wouldn't worry too much about that.

It'd be good to try and hunt that down at some point, failing CI is sad, etc.

@erikjohnston erikjohnston merged commit 57c856c into matrix-org:develop Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants