Add a test for paginated search results #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... and it fails because the fix isn't on develop yet. |
|
|
||
| my $results = $room_events->{results}; | ||
| scalar @$results == 10 or die "Expected 10 search results"; | ||
| $results->[0]{result}{event_id} eq $event_ids[19] |
There was a problem hiding this comment.
These can be done with
assert_eq( $results->[0]{result}{event_id}, $event_ids[19],
'first result event_id' );
which prints the expected/actual values on failure
|
Overall: the test appears to be expecting that search results come in batches of 10 each, but the search parameters didn't request exactly 10. This feels like it's a fragile assumption of implementation. Is there perhaps a limit parameter that can be specified? |
Set the limit on the search query. Other minor cleanups.
|
good point about the implicit limit. Now made explicit. |
|
LGTM |
|
ta |
richvdh
added a commit
that referenced
this pull request
Dec 17, 2015
Add a test for paginated search results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests the fix added at matrix-org/synapse#447