Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Backfilled events whose prev_events are in a different...' test #1059

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

erikjohnston
Copy link
Member

This was broken in matrix-org/synapse#10272, where we made incoming federation event processing asynchronous.

The failure mode was that when we called await_sync_timeline_contains it would get event R and then separately S, where previously we'd get them down in the same batch, and so paginating from the prev_batch token returned R rather than just Q. This didn't happen previously as the call to send_event previously took long enough that by the time the test called await_sync_timeline_contains the server would have process both R and S and so they'd come down in the same batch.

After this has landed we should remove the test from the blacklist.

@erikjohnston erikjohnston merged commit e8cada5 into develop Jul 1, 2021
@erikjohnston erikjohnston deleted the erikj/fix_async_send_tests branch July 1, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants