-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
max_depth = max(row[0] for row in rows) | ||
|
||
if max_depth <= topological_ordering: | ||
raise Exception("topological_ordering is greater than forward extremeties") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe 400 here rather than 500?
Maybe comment on why this is bad.
What happens when clients try to backfill using tokens from before the purge? |
It (successfully) returns 0 events. It probably triggers backfill to remote servers, so eventually it would probably return some events once the sever had backpaginated enough. |
LGTM |
Is this already a solution for #890 - delete old data to clean up database ? |
@rubo77 Yes, though its only a basic, manual per room API atm |
@erikjohnston is this manual per room API documented somewhere or can anyone can give an example? |
In #916 I posted a gist, that could work. If it works, we should add that in the api-rst file |
@4nd3r It's briefly documented at: https://github.com/matrix-org/synapse/blob/master/docs/admin_api/purge_history_api.rst |
@erikjohnston can you take part of my example gist from #916 into that documentation? https://gist.github.com/rubo77/458eb4808d665e619feeaf556476f73f |
@erikjohnston thanks. does this API also delete uploaded media from disk? |
I updated to 0.17 now, and now my gist file works fine |
#1034 will add an example to the API Documentation |
No description provided.