This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Remove unused indices #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes removing both unused indices and indices that are subsets of other indices.
|
|
||
| -- The following indices were unused | ||
| DROP INDEX IF EXISTS remote_media_cache_thumbnails_media_id; | ||
| DROP INDEX IF EXISTS evauth_edges_auth_id; | ||
| DROP INDEX IF EXISTS topics_room_id; |
There was a problem hiding this comment.
I think that either I'd want to keep this index or get rid of the entire table given that it is write only in synapse, and can be fairly easily constructed from the state tables for ad-hoc queries.
|
Other than the topics table it LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes removing both unused indices and indices that are subsets of other indices.