Stop Auth methods from polling the config on every req.

changelog.d/7420.misc

@@ -0,0 +1 @@
+Prevent methods in `synapse.handlers.auth` from polling the homeserver config every request.

synapse/api/auth.py

@@ -78,6 +78,18 @@ def __init__(self, hs):
         register_cache("cache", "token_cache", self.token_cache)
 
         self._account_validity = hs.config.account_validity
+        self._track_appservice_user_ips = self.hs.config.track_appservice_user_ips
+        self._macaroon_secret_key = self.hs.config.macaroon_secret_key
+        self._server_notices_mxid = self.hs.config.server_notices_mxid
+        self._hs_disabled = self.hs.config.hs_disabled
+        self._limit_usage_by_mau = self.hs.config.limit_usage_by_mau
+        self._hs_disabled_message = self.hs.config.hs_disabled_message
+        self._admin_contact = self.hs.config.admin_contact
+        self._limit_usage_by_mau = self.hs.config.limit_usage_by_mau
+        self._mau_limits_reserved_threepids = (
+            self.hs.config.mau_limits_reserved_threepids
+        )
+        self._max_mau_value = self.hs.config.max_mau_value
 
     @defer.inlineCallbacks
     def check_from_context(self, room_version: str, event, context, do_sig_check=True):
@@ -191,7 +203,7 @@ def get_user_by_req(
                 opentracing.set_tag("authenticated_entity", user_id)
                 opentracing.set_tag("appservice_id", app_service.id)
 
-                if ip_addr and self.hs.config.track_appservice_user_ips:
+                if ip_addr and self._track_appservice_user_ips:
                     yield self.store.insert_client_ip(
                         user_id=user_id,
                         access_token=access_token,
@@ -454,7 +466,7 @@ def validate_macaroon(self, macaroon, type_string, user_id):
         # access_tokens include a nonce for uniqueness: any value is acceptable
         v.satisfy_general(lambda c: c.startswith("nonce = "))
 
-        v.verify(macaroon, self.hs.config.macaroon_secret_key)
+        v.verify(macaroon, self._macaroon_secret_key)
 
     def _verify_expiry(self, caveat):
         prefix = "time < "
@@ -685,20 +697,20 @@ def check_auth_blocking(self, user_id=None, threepid=None, user_type=None):
         # Never fail an auth check for the server notices users or support user
         # This can be a problem where event creation is prohibited due to blocking
         if user_id is not None:
-            if user_id == self.hs.config.server_notices_mxid:
+            if user_id == self._server_notices_mxid:
                 return
             if (yield self.store.is_support_user(user_id)):
                 return
 
-        if self.hs.config.hs_disabled:
+        if self._hs_disabled:
             raise ResourceLimitError(
                 403,
-                self.hs.config.hs_disabled_message,
+                self._hs_disabled_message,
                 errcode=Codes.RESOURCE_LIMIT_EXCEEDED,
-                admin_contact=self.hs.config.admin_contact,
+                admin_contact=self._admin_contact,
                 limit_type=LimitBlockingTypes.HS_DISABLED,
             )
-        if self.hs.config.limit_usage_by_mau is True:
+        if self._limit_usage_by_mau is True:
             assert not (user_id and threepid)
 
             # If the user is already part of the MAU cohort or a trial user
@@ -713,21 +725,19 @@ def check_auth_blocking(self, user_id=None, threepid=None, user_type=None):
             elif threepid:
                 # If the user does not exist yet, but is signing up with a
                 # reserved threepid then pass auth check
-                if is_threepid_reserved(
-                    self.hs.config.mau_limits_reserved_threepids, threepid
-                ):
+                if is_threepid_reserved(self._mau_limits_reserved_threepids, threepid):
                     return
             elif user_type == UserTypes.SUPPORT:
                 # If the user does not exist yet and is of type "support",
                 # allow registration. Support users are excluded from MAU checks.
                 return
             # Else if there is no room in the MAU bucket, bail
             current_mau = yield self.store.get_monthly_active_count()
-            if current_mau >= self.hs.config.max_mau_value:
+            if current_mau >= self._max_mau_value:
                 raise ResourceLimitError(
                     403,
                     "Monthly Active User Limit Exceeded",
-                    admin_contact=self.hs.config.admin_contact,
+                    admin_contact=self._admin_contact,
                     errcode=Codes.RESOURCE_LIMIT_EXCEEDED,
                     limit_type=LimitBlockingTypes.MONTHLY_ACTIVE_USER,
                 )