This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Cleanups and additions to the module API #6688
Merged
+61
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some useful things, such as error types and logcontext handling, to the API. Make `hs` a private member to dissuade people from using it (hopefully they aren't already). Add a couple of new methods (`record_user_external_id` and `generate_short_term_login_token`).
Some modules don't need any config, so having to define a `config` property just to keep the loader happy is a bit annoying.
|
(RedirectException is in #6687) |
erikjohnston
approved these changes
Jan 13, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '608bf7d74': changelog Handle `config` not being set for synapse plugin modules Cleanups and additions to the module API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some useful things, such as error types and logcontext handling, to the API.
Make
hsa private member to dissuade people from using it (hopefully they aren't already).Add a couple of new methods (
record_user_external_idandgenerate_short_term_login_token).Make
configoptional in the configuration file when loading a module.