Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Silence mypy errors for files outside those specified #6512

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Dec 10, 2019

This is required for the database config splitting up PR, as a file in config/ needs to import a class in storage/, which then leads to lots and lots of errors.

@erikjohnston erikjohnston requested a review from a team December 10, 2019 14:20
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a file in config/ needs to import a class in storage/

this feels like a bad thing architecturally, tbh.

but otherwise lgtm

@erikjohnston erikjohnston merged commit 239d86a into develop Dec 11, 2019
@erikjohnston
Copy link
Member Author

a file in config/ needs to import a class in storage/

this feels like a bad thing architecturally, tbh.

but otherwise lgtm

Its not ideal, but I think configuring mypy like this will help us expand our mypy coverage anyway

@erikjohnston erikjohnston deleted the erikj/silence_mypy branch January 9, 2020 15:47
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '239d86a13':
  Newsfile
  Silence mypy errors for files outside those specified
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants