Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Document lint.sh & allow application to specified files only #6312

Merged

Conversation

neiljp
Copy link
Contributor

@neiljp neiljp commented Oct 31, 2019

Thanks to @anoadragon453 for pointing me towards lint.sh 👍

So others can find it, this PR adds a note about it in the Code Style section of CONTRIBUTING.

Since the tool can take a while to run, I've amended it slightly to enable running it on specified files (if any arguments are provided), and adjusted the documentation added in the first commit accordingly. Now I can just run it on specific updated files, rather than it taking 4-5m here :)

@neiljp neiljp marked this pull request as ready for review October 31, 2019 18:45
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise!

CONTRIBUTING.rst Outdated Show resolved Hide resolved
scripts-dev/lint.sh Show resolved Hide resolved
Documentation updated to indicate this is possible.

Signed-off-by: neiljp (Neil Pilgrim) <[email protected]>
Signed-off-by: neiljp (Neil Pilgrim) <[email protected]>
@neiljp neiljp force-pushed the 2019-10-lint.sh-improvements branch from f737e08 to 1a97c9d Compare October 31, 2019 23:02
@anoadragon453 anoadragon453 merged commit befd58f into matrix-org:develop Nov 1, 2019
@anoadragon453
Copy link
Member

Thanks!

babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'befd58f47':
  Document lint.sh & allow application to specified files only (#6312)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants