Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Split state groups into a separate data store #6296

Merged
merged 15 commits into from
Dec 20, 2019
Merged

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Oct 30, 2019

Based on #6294 and #6295.

Commits are independently reviewable, though all of this should just be copy and paste from main to state data stores (modulo updating things to point to the right data store).

(Split out from #6245.)

@erikjohnston erikjohnston requested a review from a team October 30, 2019 16:06
@erikjohnston erikjohnston removed the request for review from a team October 31, 2019 16:00
@erikjohnston erikjohnston requested a review from a team November 18, 2019 18:31
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well sure. I guess I'm largely going to take your word for this.

One thought: I'm already beginning to page out what was the idea behind the architecture and the difference between the different storage layers. It might be worth trying to update the text at https://github.com/matrix-org/synapse/blob/master/synapse/storage/__init__.py#L18.

@@ -0,0 +1,19 @@
/* Copyright 2016 OpenMarket Ltd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't having two delta files with the same name mean that only one gets run? or am I misremembering how this works?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right. I might add a sanity check to cause synapse to explode if there are multiple deltas with the same name

synapse/storage/prepare_database.py Outdated Show resolved Hide resolved
@richvdh
Copy link
Member

richvdh commented Nov 27, 2019

One thought: I'm already beginning to page out what was the idea behind the architecture and the difference between the different storage layers. It might be worth trying to update the text at https://github.com/matrix-org/synapse/blob/master/synapse/storage/__init__.py#L18.

Scratch this; what is needed is for me to actually read it.

Having done so, I think it could do with some expansion and clarification, but that's probably a separate topic.

@erikjohnston
Copy link
Member Author

Oh, I've also managed to put the state deltas in the wrong place (deltas/ vs delta/), which I didn't pick up due to the full schema.

@erikjohnston erikjohnston merged commit 75d8f26 into develop Dec 20, 2019
@erikjohnston erikjohnston deleted the erikj/state_store branch January 9, 2020 15:47
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '75d8f26ac':
  Split state groups into a separate data store (#6296)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants