-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Split state groups into a separate data store #6296
Conversation
…apse into erikj/state_store
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well sure. I guess I'm largely going to take your word for this.
One thought: I'm already beginning to page out what was the idea behind the architecture and the difference between the different storage layers. It might be worth trying to update the text at https://github.com/matrix-org/synapse/blob/master/synapse/storage/__init__.py#L18.
@@ -0,0 +1,19 @@ | |||
/* Copyright 2016 OpenMarket Ltd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't having two delta files with the same name mean that only one gets run? or am I misremembering how this works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you're right. I might add a sanity check to cause synapse to explode if there are multiple deltas with the same name
Scratch this; what is needed is for me to actually read it. Having done so, I think it could do with some expansion and clarification, but that's probably a separate topic. |
Oh, I've also managed to put the state deltas in the wrong place ( |
b7ae670
to
335514f
Compare
* commit '75d8f26ac': Split state groups into a separate data store (#6296)
Based on #6294 and #6295.Commits are independently reviewable, though all of this should just be copy and paste from
main
tostate
data stores (modulo updating things to point to the right data store).(Split out from #6245.)