This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add support for changing the actions for default rules #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, as you say IRL, may want to strip out any remaining rules with prio class -1 or otherwise handle this, although of course it's perfectly safe until we remove a default rule! Probably should do the check now though rather than leaving a heffalump trap for someone. Otherwise lgtm. |
|
I've removed all the rules with negative prio class, b3fb790 |
|
lgtm, merge it! :) |
See matrix-org/matrix-spec-proposals#283 Works by adding dummy rules to the push rules table with a negative priority class and then using those rules to clobber the default rule actions when adding the default rules in ``list_with_base_rules``
NegativeMjark
force-pushed
the
markjh/change_action
branch
from
b3fb790 to
de27f7f
Compare
NegativeMjark
added a commit
that referenced
this pull request
Feb 26, 2016
Add support for changing the actions for default rules See matrix-org/matrix-spec-proposals#283 Works by adding dummy rules to the push rules table with a negative priority class and then using those rules to clobber the default rule actions when adding the default rules in ``list_with_base_rules``
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See matrix-org/matrix-spec-proposals#283
Works by adding dummy rules to the push rules table with a negative priority class and then using those rules to clobber the default rule actions when adding the default rules in
list_with_base_rules