Show correct error when logging out and access token is missing

[aaronraimist]

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file
• Pull request includes a sign off

Fixes #5255

⟩ curl -XPOST "http://localhost:8700/_matrix/client/r0/logout"
{
    "errcode": "M_MISSING_TOKEN",
    "error": "Missing access token."
}

⟩ curl -XPOST "http://localhost:8700/_matrix/client/r0/logout?access_token=test"

{
    "errcode": "M_UNKNOWN_TOKEN",
    "error": "Invalid macaroon passed."
}

[codecov]

Codecov Report

Merging #5256 into develop will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #5256      +/-   ##
===========================================
+ Coverage    62.78%   62.78%   +<.01%     
===========================================
  Files          341      341              
  Lines        35452    35448       -4     
  Branches      5798     5799       +1     
===========================================
- Hits         22258    22257       -1     
+ Misses       11628    11625       -3     
  Partials      1566     1566

[richvdh]

Thanks for this! A couple of questions though.

Can we not just let the exception propagate?

Also... I think I'm going to insist on a regression test for this, maybe in sytest. If it's worth fixing, it's worth making sure it stays fixed this time.

[aaronraimist]

Fixed, and sytest here matrix-org/sytest#613

[anoadragon453]

@aaronraimist Could you fix the linting please?

[aaronraimist]

Should be fixed