This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make sure we're not registering the same 3pid twice #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5071 +/- ##
===========================================
- Coverage 61.57% 60.43% -1.15%
===========================================
Files 332 328 -4
Lines 34271 34096 -175
Branches 5651 5628 -23
===========================================
- Hits 21103 20605 -498
- Misses 11653 12020 +367
+ Partials 1515 1471 -44 |
erikjohnston
approved these changes
Apr 17, 2019
babolivier
force-pushed
the
babolivier/3pid-check
branch
from
5b0bead to
600ec04
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user hits
/register/{medium}/requestTokentwice then clicks on each link from the two activation emails, they would register the same 3pid twice because we only check that in calls torequestToken.