This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync_handler = self.hs.get_handlers().sync_handler | ||
_, ephemeral_by_room = yield sync_handler.ephemeral_by_room( | ||
sync_config, now_token | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than abusing SyncConfig it'd probably be cleaner to add a storage function get_receipts_for_room
, e.g.:
@cached(num_args=3)
def get_receipts_for_room_for_room(self, room_id, user_id, receipt_type):
return self._simple_select_list(
table="receipts_linearized",
keyvalues={
"room_id": room_id,
"receipt_type": receipt_type,
"user_id": user_id,
},
retcols=("event_id"),
desc="get_receipts_for_room",
)
or possibly using _simple_select_one_onecol
…ken up and it's not an event
…che invalidation to the receipts storage because there wasn't any, and remove a method that was unused.
ptal, at least for the bits you didn't help me write. Have added the index on user_id to receipts_linearized too. |
Other than unindenting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the 'push notification badge count' part of https://github.com/vector-im/vector-web/issues/469