This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Limit in flight DNS requests #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/limit_inflight_dns
branch
from
7f479bb to
58dff0e
Compare
This is to work around a bug in twisted where a large number of concurrent DNS requests cause it to tight loop forever. c.f. https://twistedmatrix.com/trac/ticket/9620#ticket
erikjohnston
force-pushed
the
erikj/limit_inflight_dns
branch
from
58dff0e to
02491e0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5037 +/- ##
===========================================
- Coverage 61.6% 61.58% -0.02%
===========================================
Files 332 332
Lines 34237 34267 +30
Branches 5647 5647
===========================================
+ Hits 21090 21102 +12
- Misses 11633 11651 +18
Partials 1514 1514 |
|
It's probably fine(tm)? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to work around a bug in twisted where a large number of
concurrent DNS requests cause it to tight loop forever.
c.f. https://twistedmatrix.com/trac/ticket/9620#ticket