This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix from_server buglet in get_keys_from_perspectives #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure we store the name of the server the keys came from, rather than the origin server, after doing a fetch-from-perspectives.
Codecov Report
@@ Coverage Diff @@
## develop #5024 +/- ##
========================================
Coverage 61.59% 61.59%
========================================
Files 332 332
Lines 34225 34225
Branches 5643 5643
========================================
Hits 21081 21081
Misses 11630 11630
Partials 1514 1514 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #5024 +/- ##
========================================
Coverage 61.59% 61.59%
========================================
Files 332 332
Lines 34225 34225
Branches 5643 5643
========================================
Hits 21081 21081
Misses 11630 11630
Partials 1514 1514 |
erikjohnston
approved these changes
Apr 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure we store the name of the server the keys came from, rather than the
origin server, after doing a fetch-from-perspectives.