This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Avoid rebuilding Edu objects in worker mode #4770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4770 +/- ##
===========================================
- Coverage 75.13% 75.02% -0.12%
===========================================
Files 340 340
Lines 34918 35000 +82
Branches 5722 5748 +26
===========================================
+ Hits 26237 26260 +23
- Misses 7067 7123 +56
- Partials 1614 1617 +3 |
richvdh
force-pushed
the
rav/optimise_edu_replication
branch
from
1913644 to
dc94ea4
Compare
In worker mode, on the federation sender, when we receive an edu for sending over the replication socket, it is parsed into an Edu object. There is no point extracting the contents of it so that we can then immediately build another Edu.
richvdh
force-pushed
the
rav/optimise_edu_replication
branch
from
dc94ea4 to
e1db047
Compare
erikjohnston
approved these changes
Mar 4, 2019
|
\o/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In worker mode, on the federation sender, when we receive an edu for sending over the replication socket, it is parsed into an
Eduobject. There is no point extracting the contents of it so that we can then immediately build anotherEdu.