Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Neilj/readme wellknown #4766

Closed
wants to merge 9 commits into from
Closed

Neilj/readme wellknown #4766

wants to merge 9 commits into from

Conversation

neilisfragile
Copy link
Contributor

No description provided.

@neilisfragile neilisfragile changed the base branch from master to develop February 28, 2019 15:17
@neilisfragile neilisfragile requested a review from a team February 28, 2019 15:21
INSTALL.md Outdated Show resolved Hide resolved
@@ -134,6 +134,11 @@ ACME setup
For details on having Synapse manage your federation TLS certificates
automatically, please see `<docs/ACME.md>`_.

.well-known setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer it if we could avoid adding more top-level headings to the README, which is already pretty complicated.

README.rst Outdated Show resolved Hide resolved
For those of you upgrading your TLS certificate in readiness for Synapse 1.0,
please take a look at `our guide <https://github.com/matrix-org/synapse/blob/master/docs/MSC1711_certificates_FAQ.md#configuring-certificates-for-compatibility-with-synapse-100>`_

Having created a valid TLS certificate you can then configure your homeserver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice we now encourage people to create their configs up-front, and then tweak them later to enable TLS and federation. This is therefore backwards.

@@ -242,8 +247,16 @@ should have the format ``_matrix._tcp.<yourdomain.com> <ttl> IN SRV 10 0 <port>
Note that the server hostname cannot be an alias (CNAME record): it has to point
directly to the server hosting the synapse instance.

You can then configure your homeserver to use ``<yourdomain.com>`` as the domain in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda feel like it would make more sense to move the whole "setting up federation" section to a separate file, rather than just the well-known info, but up to you.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated
its user-ids, by setting ``server_name``::
If it is not possible to acquire a certificate valid for you matrix domain,
the correct method is create a .well-known entry. For more details on how to
configure .well-known `see <https://github.com/matrix-org/synapse/blob/master/docs/well_known.md`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing full-stop

README.rst Outdated Show resolved Hide resolved
README.rst Outdated
configure .well-known `see <https://github.com/matrix-org/synapse/blob/master/docs/well_known.md`_

For those of you upgrading your TLS certificate in readiness for Synapse 1.0,
please take a look at `our guide <https://github.com/matrix-org/synapse/blob/master/docs/MSC1711_certificates_FAQ.md#configuring-certificates-for-compatibility-with-synapse-100>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing full-stop

docs/well-known.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #4766 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4766      +/-   ##
===========================================
- Coverage     75.1%   75.09%   -0.01%     
===========================================
  Files          340      340              
  Lines        34918    34918              
  Branches      5722     5722              
===========================================
- Hits         26224    26223       -1     
+ Misses        7083     7078       -5     
- Partials      1611     1617       +6

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #4766 into develop will decrease coverage by 7.47%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4766      +/-   ##
===========================================
- Coverage     75.1%   67.62%   -7.48%     
===========================================
  Files          340      340              
  Lines        34918    34918              
  Branches      5722     5722              
===========================================
- Hits         26224    23613    -2611     
- Misses        7083     9655    +2572     
- Partials      1611     1650      +39

docs/well-known.md Outdated Show resolved Hide resolved
## Configuring `.well-known`

1. Give synapse a certificate corresponding to the target domain
(`customer.example.com`). Currently Synapse's ACME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this feels a bit harder to follow than it could be otherwise since ExampleCorp supposedly owns example.com but then that Matrix HS supplier controls customer.example.com if I am following, which seems unlikely... Perhaps customer.example.com should be customer.homeservers.com or really anything other than *.example.com, so it's clear that they are controlled by different parties?

Co-Authored-By: neilisfragile <[email protected]>
@richvdh
Copy link
Member

richvdh commented Mar 8, 2019

superceded by #4832

@richvdh richvdh closed this Mar 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants