Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Enable ACME support in the docker image #4566

Merged
merged 8 commits into from
Feb 5, 2019
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Feb 5, 2019

Also:

@richvdh richvdh requested a review from a team February 5, 2019 11:27
@richvdh
Copy link
Member Author

richvdh commented Feb 5, 2019

fixes #4548 I hope

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits

docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #4566 into release-v0.99.0 will decrease coverage by 0.45%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-v0.99.0    #4566      +/-   ##
===================================================
- Coverage            74.91%   74.45%   -0.46%     
===================================================
  Files                  338      338              
  Lines                34495    35093     +598     
  Branches              5619     5789     +170     
===================================================
+ Hits                 25841    26130     +289     
- Misses                7071     7351     +280     
- Partials              1583     1612      +29

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@richvdh richvdh merged commit 40b35fb into release-v0.99.0 Feb 5, 2019
@richvdh richvdh deleted the rav/docker_install branch February 5, 2019 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants