This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
ACME config cleanups #4525
Merged
ACME config cleanups #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the weird url-but-not-actually-a-url-string doesn't handle IPv6 addresses without extra quoting. Building a string which you are about to parse again seems like a weird choice. Let's just use listenTCP, which is consistent with what we do elsewhere.
make it look a bit more consistent with everything else, and tweak the defaults to listen on port 80.
hawkowl
approved these changes
Jan 30, 2019
erikjohnston
approved these changes
Jan 30, 2019
| self.acme_port = acme_config.get("port", 8449) | ||
| self.acme_bind_addresses = acme_config.get("bind_addresses", ["127.0.0.1"]) | ||
| self.acme_port = acme_config.get("port", 80) | ||
| self.acme_bind_addresses = acme_config.get("bind_addresses", ['::', '0.0.0.0']) |
There was a problem hiding this comment.
It feels odd that the default will cause warnings?
There was a problem hiding this comment.
well, mostly I wanted it to be consistent with what we do for the other listeners. I kinda agree, but :/
There was a problem hiding this comment.
fair enough, we can always clean it up later if necessary
Codecov Report
@@ Coverage Diff @@
## develop #4525 +/- ##
===========================================
+ Coverage 74.74% 74.75% +<.01%
===========================================
Files 337 337
Lines 34447 34456 +9
Branches 5615 5616 +1
===========================================
+ Hits 25749 25758 +9
+ Misses 7110 7108 -2
- Partials 1588 1590 +2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle listening for ACME requests on IPv6 addresses:
Make the default config look a bit more consistent with everything else, and
tweak the defaults to listen on port 80.