This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix replication for room v3 #4523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not correctly quoting the path fragments over http replication, which meant that it exploded when the event IDs had a slash in them
Codecov Report
@@ Coverage Diff @@
## develop #4523 +/- ##
===========================================
+ Coverage 74.7% 74.73% +0.03%
===========================================
Files 337 337
Lines 34447 34447
Branches 5615 5615
===========================================
+ Hits 25732 25744 +12
+ Misses 7124 7112 -12
Partials 1591 1591 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not correctly quoting the path fragments over http replication,
which meant that it exploded when the event IDs had a slash in them