This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Actually look up required remote server key IDs #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set.union() is a side-effect-free function that returns the union of two sets. This clearly wanted .update(), which is the side-effecting mutator version.
NegativeMjark
added a commit
that referenced
this pull request
Dec 21, 2015
Actually look up required remote server key IDs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes SYN-558
set.union() is a side-effect-free function that returns the union of two
sets. This clearly wanted .update(), which is the side-effecting mutator
version.
This also makes sytest run somewhat faster too; without:
real 1m9.419s
with:
real 1m5.685s
I expect a realworld test would show a much larger improvement here; because synapses under sytest spend a huge amount of their time just provisioning new testing users who hardly ever send federated traffic, whereas realworld cases would send a lot more federation about the place.
Also some quick stats of client logs in sytest:
$ grep "/key/v2/server/" log-broken.log | grep GET | wc -l
31
$ grep "/key/v2/server/" log-fixed.log | grep GET | wc -l
8