This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fixup calls to comput_event_signature
#4510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/fixup_compute_event_signature
branch
from
fcb8eb6 to
0c55b77
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4510 +/- ##
===========================================
- Coverage 74.76% 74.76% -0.01%
===========================================
Files 336 336
Lines 34180 34180
Branches 5559 5559
===========================================
- Hits 25556 25554 -2
- Misses 7048 7049 +1
- Partials 1576 1577 +1 |
Yup thanks, its in the commit comment but forgot to update the PR comment |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently pass FrozenEvent instead of
dicttocompute_event_signature, which works by accident due todict(event)producing the correct result.