Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix UnboundLocalError in post_urlencoded_get_json #4460

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 24, 2019

This could cause exceptions if the id server returned 4xx responses.

(it got broken in 2d2828d)

This could cause exceptions if the id server returned 4xx responses.
@richvdh richvdh requested a review from a team January 24, 2019 11:40
@codecov-io
Copy link

Codecov Report

Merging #4460 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4460      +/-   ##
===========================================
+ Coverage    74.79%   74.82%   +0.02%     
===========================================
  Files          336      336              
  Lines        33997    33997              
  Branches      5527     5527              
===========================================
+ Hits         25429    25439      +10     
+ Misses        7002     6991      -11     
- Partials      1566     1567       +1

@richvdh richvdh merged commit f4697b5 into develop Jan 24, 2019
@richvdh richvdh deleted the rav/fix_unbound_local_error branch January 24, 2019 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants