This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix bug when removing duplicate rows from user_ips #4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by accidentally overwritting a `last_seen` variable in a for loop, causing the wrong value to be written to the progress table. The result of which was that we didn't scan sections of the table when searching for duplicates, and so some duplicates did not get deleted.
erikjohnston
commented
Jan 22, 2019
| if row: | ||
| return row[0] | ||
| else: | ||
| return None |
There was a problem hiding this comment.
This is just moving the row[0] from the if statement below into the function, as it feels cleaner
richvdh
reviewed
Jan 22, 2019
richvdh
reviewed
Jan 22, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4434 +/- ##
===========================================
+ Coverage 73.68% 73.72% +0.03%
===========================================
Files 300 300
Lines 29703 29705 +2
Branches 4882 4882
===========================================
+ Hits 21887 21899 +12
+ Misses 6386 6378 -8
+ Partials 1430 1428 -2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by accidentally overwritting a
last_seenvariablein a for loop, causing the wrong value to be written to the progress
table. The result of which was that we didn't scan sections of the table
when searching for duplicates, and so some duplicates did not get
deleted.