This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make key fetches use regular federation client #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All this magic is redundant.
Codecov Report
@@ Coverage Diff @@
## develop #4426 +/- ##
===========================================
+ Coverage 73.64% 73.66% +0.02%
===========================================
Files 300 299 -1
Lines 29801 29703 -98
Branches 4896 4882 -14
===========================================
- Hits 21947 21882 -65
+ Misses 6417 6390 -27
+ Partials 1437 1431 -6 |
hawkowl
reviewed
Jan 22, 2019
| @@ -514,20 +515,6 @@ def get_server_verify_key_v2_direct(self, server_name, key_ids): | |||
| if "tls_fingerprints" not in response: | |||
| raise KeyLookupError("Key response missing TLS fingerprints") | |||
|
|
|||
| certificate_bytes = crypto.dump_certificate( | |||
We don't need this any more, and we are likely to remove it from the spec soon enough.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may as well just use the regular federation client, which saves alot of
magic.