Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Implement server side of MSC1794 - Federation v2 Invite API #4402

Merged
merged 3 commits into from
Jan 21, 2019

Conversation

erikjohnston
Copy link
Member

The MSC hasn't been merged yet, but is in FCP. We can always change the implementation in the (unlikely?) event the MSC changes.

Based on #4390

@erikjohnston
Copy link
Member Author

The error looks to be a race/bug that wasn't introduced by this PR, so can be ignored as I'll fix it separately

@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #4402 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4402      +/-   ##
===========================================
+ Coverage    73.64%   73.66%   +0.01%     
===========================================
  Files          300      300              
  Lines        29789    29801      +12     
  Branches      4896     4896              
===========================================
+ Hits         21938    21952      +14     
+ Misses        6411     6409       -2     
  Partials      1440     1440

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (modulo comments on #4390), but we're gonna need some tests.

@erikjohnston
Copy link
Member Author

See matrix-org/sytest#545 for tests

turt2live added a commit to matrix-org/matrix-spec-proposals that referenced this pull request Jan 29, 2019
Original proposal: #1794
Implementation proofs:
* matrix-org/synapse#4402
* matrix-org/synapse#4496

There are no changes from the original proposal.
turt2live added a commit to matrix-org/matrix-spec-proposals that referenced this pull request Jan 29, 2019
Original proposal: #1794
Implementation proofs:
* matrix-org/synapse#4402
* matrix-org/synapse#4496

There are no changes from the original proposal.
@erikjohnston erikjohnston deleted the erikj/fed_v2_invite_server branch March 5, 2019 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants