This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix IP URL previews on Python 3 #4215
Merged
Merged
Changes from 26 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
9e0ae2f
fix
hawkowl 1474953
changelog
hawkowl 31e0fd9
fixes
hawkowl 1520252
fixes
hawkowl ec14bca
fixes
hawkowl 7af04df
fix pep8
hawkowl 606e39b
fix pep8
hawkowl 759169b
add some code coverage to blacklists
hawkowl a2f7ae1
tests
hawkowl a94ca42
Merge remote-tracking branch 'origin/develop' into hawkowl/ip-preview
hawkowl ca82572
fix pep8
hawkowl 4c246c0
Merge remote-tracking branch 'origin/develop' into hawkowl/ip-preview
hawkowl fc1dd48
cleanup
hawkowl c70d2a1
log when we block
hawkowl 5756f64
docstring
hawkowl 0421f0b
docstring
hawkowl e59a5ee
comment
hawkowl 4357b85
Merge remote-tracking branch 'origin/develop' into hawkowl/ip-preview
hawkowl d82e498
fix
hawkowl 1210131
merge in tests
hawkowl 6fade49
fix
hawkowl 168a494
fix
hawkowl 920625f
fix
hawkowl 7d17b47
fix py2
hawkowl 1d40dd5
Merge remote-tracking branch 'origin/develop' into hawkowl/ip-preview
hawkowl 79a5655
fix missing hyperlink
hawkowl aac9bb4
Merge remote-tracking branch 'origin/develop' into hawkowl/ip-preview
hawkowl 34952ce
review comments
hawkowl 9e64ab8
review comments
hawkowl 3b9e190
urllib does what we need here
hawkowl cfa8f6f
Merge branch 'develop' into hawkowl/ip-preview
hawkowl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,4 +9,3 @@ source= | |
|
||
[report] | ||
precision = 2 | ||
ignore_errors = True |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,3 +57,4 @@ env/ | |
|
||
.vscode/ | ||
.ropeproject/ | ||
.coverage.* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Getting URL previews of IP addresses no longer fails on Python 3. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to document this in the README (grep for
lxml
- there's more than one place) as well as the upgrade notes, and put something in the changelog about it, to stop people getting surprised by it suddenly not working.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only affect people on Twisteds older than 17.5, which hard depends on hyperlink. (I guess this affects xenial and so?) Maybe I should add it to our pip dependencies?