Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Check logcontexts before and after each test #4190

Merged
merged 6 commits into from
Nov 27, 2018
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Nov 15, 2018

No description provided.

@richvdh
Copy link
Member Author

richvdh commented Nov 15, 2018

Obviously, it all passes just fine on this branch...

@richvdh richvdh requested review from a team and removed request for a team November 15, 2018 21:54
@richvdh richvdh changed the title Add better diagnostics to flakey keyring test Clean up some problems with leaky logcontexts in the tests Nov 15, 2018
@richvdh
Copy link
Member Author

richvdh commented Nov 19, 2018

It stopped passing fine on this branch. The fixes are pulled out to #4204, and this is now based on that.

@richvdh richvdh changed the title Clean up some problems with leaky logcontexts in the tests Check logcontexts before and after each test Nov 19, 2018
@richvdh richvdh requested a review from a team November 19, 2018 17:35
@richvdh richvdh force-pushed the rav/debug/keyring_tests branch from 1efa2f4 to 80cf9b8 Compare November 20, 2018 12:05
@richvdh
Copy link
Member Author

richvdh commented Nov 21, 2018

I'm not quite sure why this is failing. It's possible #4209 or #4213 or similar will fix it.

@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #4190 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4190      +/-   ##
===========================================
- Coverage    66.65%   66.65%   -0.01%     
===========================================
  Files          299      299              
  Lines        29796    29796              
  Branches      4871     4871              
===========================================
- Hits         19861    19860       -1     
- Misses        8501     8503       +2     
+ Partials      1434     1433       -1
Impacted Files Coverage Δ
synapse/handlers/presence.py 76.26% <0%> (-0.21%) ⬇️
synapse/handlers/search.py 77.5% <0%> (ø) ⬆️
synapse/handlers/federation.py 61.62% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80527b5...0900e62. Read the comment docs.

@hawkowl hawkowl merged commit a44c0a0 into develop Nov 27, 2018
@hawkowl hawkowl deleted the rav/debug/keyring_tests branch November 27, 2018 02:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants