This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Drop incoming events from federation for unknown rooms #4166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we receive events over federation we will need to know the room version to be able to correctly handle them, e.g. once we start changing event formats. Currently, we attempt to handle events in unknown rooms.
richvdh
reviewed
Nov 8, 2018
There was a problem hiding this comment.
looks good so far.
There is some code in FederationHandler.on_receive_pdu which checks if we're currently in a room for a given event, and if we're not, then allows the event through in the special case that we have never been in that room. I think that should be simplified.
|
Fixes #3422? |
Co-Authored-By: erikjohnston <[email protected]>
Co-Authored-By: erikjohnston <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do this as in future we'll need to know the version of the room before being able to parse the event fully.