Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix bug when invalidating destination retry timings #3991

Merged
merged 3 commits into from
Oct 2, 2018

Conversation

erikjohnston
Copy link
Member

No description provided.

@erikjohnston erikjohnston requested a review from a team October 2, 2018 14:49
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you link to the original PR from here please

@@ -0,0 +1 @@
Fix bug when invalidating destination retry timings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update this to match the description of the original PR so that the changelog entries get combined, please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, good point

@erikjohnston erikjohnston force-pushed the erikj/fix_pop_retry_cache branch from d3a8066 to 8f614f8 Compare October 2, 2018 14:54
@erikjohnston
Copy link
Member Author

This was broken in #3933

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@erikjohnston erikjohnston merged commit 25baf3b into develop Oct 2, 2018
@erikjohnston erikjohnston deleted the erikj/fix_pop_retry_cache branch December 12, 2018 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants