This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Update instructions to point to pip install #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1224 |
richvdh
reviewed
Oct 1, 2018
There was a problem hiding this comment.
The tarball is referenced at other places too (eg, under Arch Linux and OpenBSD)
There is also an UPGRADE.rst which needs updating.
(while you're in the README: any chance you can delete the stuff at https://github.com/matrix-org/synapse/blob/master/README.rst#ipv6 about needing a new twisted, since we now require that by default)
.circleci/merge_base_branch.sh
Outdated
| @@ -9,13 +9,16 @@ source $BASH_ENV | |||
|
|
|||
| if [[ -z "${CIRCLE_PR_NUMBER}" ]] | |||
| then | |||
| echo "Can't figure out what the PR number is!" | |||
| exit 1 | |||
| echo "Can't figure out what the PR number is! Assuming develop." | |||
There was a problem hiding this comment.
this looks unrelated, though useful.
I would s/Assuming develop/Assuming it will be based on develop/ though.
richvdh
previously requested changes
Oct 1, 2018
| @@ -533,9 +512,7 @@ fix try re-installing from PyPI or directly from | |||
|
|
|||
| # Install from PyPI | |||
| pip install --user --upgrade --force pynacl | |||
|
|
|||
| # Install from github | |||
| pip install --user https://github.com/pyca/pynacl/tarball/master | |||
richvdh
reviewed
Oct 1, 2018
| @@ -459,7 +459,7 @@ Troubleshooting | |||
| Troubleshooting Installation | |||
| ---------------------------- | |||
|
|
|||
| Synapse requires pip 1.7 or later, so if your OS provides too old a version you | |||
| Synapse requires pip 8 or later, so if your OS provides too old a version you | |||
There was a problem hiding this comment.
1.7, ahh, such a classic pip release (which literally won't install packages now)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.