Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove get_destination_retry_timings cache #3914

Merged
merged 4 commits into from
Sep 20, 2018

Conversation

erikjohnston
Copy link
Member

Currently we rely on the master to invalidate this cache promptly.
However, after having moved most federation endpoints off of master this
no longer happens, causing outbound fedeariont to get blackholed.

Fixes #3798

@erikjohnston erikjohnston requested a review from a team September 19, 2018 13:19
Currently we rely on the master to invalidate this cache promptly.
However, after having moved most federation endpoints off of master this
no longer happens, causing outbound fedeariont to get blackholed.

Fixes #3798
@erikjohnston erikjohnston force-pushed the erikj/remove_retry_cache branch from 3680710 to 83ee559 Compare September 19, 2018 13:23
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably do with deleting the XXX at line 199.

otherwise LGTM

@@ -0,0 +1 @@
Fix bug where outboud federation would stop talking to some servers when using workers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outboud

@richvdh
Copy link
Member

richvdh commented Sep 19, 2018

fedeariont

NOES, not the fearsome FEDEARIONT!

@erikjohnston
Copy link
Member Author

I wonder if there exists a tool to monitor all outbound network traffic from my computer and run it through a spell checker...

@erikjohnston erikjohnston merged commit 3fd68d5 into develop Sep 20, 2018
@erikjohnston erikjohnston deleted the erikj/remove_retry_cache branch September 20, 2018 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants