This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use a producer to stream back responses #3693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
approved these changes
Aug 14, 2018
synapse/http/server.py
Outdated
|
|
||
| producer = NoRangeStaticProducer(request, bytes_io) | ||
| producer.start() | ||
| return NOT_DONE_YET |
There was a problem hiding this comment.
Is there a reason we don't replace respond_with_json_bytes with this?
|
This is going to get replaced by #3700 and another PR. |
The problem with dumping all of the json response into the Request object at once is that doing so starts the timeout for the next request to be received: so if it takes longer than 60s to stream back the response to the client, the client never gets it. The correct solution is to use Producer; then the timeout is only started once all of the content is sent over the TCP connection. However, we then need to hook the completion logging in via notifyFinish (which is a much better way of doing things anyway), in order to correctly read the response length.
richvdh
force-pushed
the
rav/use_producer_for_responses
branch
from
9d95e43 to
6f3bf1b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with dumping all of the json response into the Request object
at once is that doing so starts the timeout for the next request to be
received: so if it takes longer than 60s to stream back the response to the
client, the client never gets it.
The correct solution is to use Producer; then the timeout is only started
once all of the content is sent over the TCP connection.
However, we then need to hook the completion logging in via notifyFinish
(which is a much better way of doing things anyway), in order to correctly
read the response length.