This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use a (hopefully) more efficient SQL query for doing recency based room search #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might want to have a comment referencing https://sqlite.org/optoverview.html#crossjoin |
|
Done |
| @@ -252,12 +252,17 @@ def search_room(self, room_id, search_term, keys, limit, pagination_token=None): | |||
| " WHERE vector @@ query AND room_id = ?" | |||
| ) | |||
| elif isinstance(self.database_engine, Sqlite3Engine): | |||
| # We use CROSS JOIN here to ensure we use the right indexes. | |||
There was a problem hiding this comment.
It might be worth elaborating on what the right indexes are. Something like "We want to use the full text search index on event_search to extract all possible matches first, then lookup those matches in the events table to get the topological ordering. We need to use the indexes in this order because sqlite refuses to MATCH unless it uses the full text search index"
|
LGTM |
erikjohnston
added a commit
that referenced
this pull request
Nov 12, 2015
Use a (hopefully) more efficient SQL query for doing recency based room search
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.