This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Refactor and optimise filter_events_for_server #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
approved these changes
Jul 16, 2018
synapse/visibility.py
Outdated
| return False | ||
| return state_key[idx + 1:] == server_name |
There was a problem hiding this comment.
Might be worth a quick comment as to why we don't use get_domain_from_id, I was a bit confused.
richvdh
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly this factors filter_events_for_server out of FederationHandler and adds a unit test for it. Then we refactor it to make it do a bit less string comparison, and add another test which does some profiling.