This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make FederationRateLimiter queue requests properly #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popitem removes the *most recent* item by default [1]. We want the oldest. Fixes #3524 [1]: https://docs.python.org/2/library/collections.html#collections.OrderedDict.popitem
erikjohnston
approved these changes
Jul 13, 2018
changelog.d/3533.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| Fix queueing of federation requests | |||
There was a problem hiding this comment.
I feel like this is too vague to go into a changelog. Something like "Fix queued federation requests being processed in the wrong order", might be better maybe?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
popitem removes the most recent item by default (1). We want the oldest.
Fixes #3524