Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add metrics to track appservice transactions #3344

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Add metrics to track appservice transactions #3344

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
604cff1
Add metrics to track appservice transactions
Half-Shot Jun 5, 2018
d6e3c2c
Let's try labels instead of label, that might work
Half-Shot Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions synapse/appservice/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,27 @@
import logging
import urllib

from prometheus_client import Counter

logger = logging.getLogger(__name__)

sent_transactions_counter = Counter(
"synapse_appservice_api_sent_transactions",
"Number of /transactions/ requests sent",
["service"]
)

failed_transactions_counter = Counter(
"synapse_appservice_api_failed_transactions",
"Number of /transactions/ requests that failed to send",
["service"]
)

sent_events_counter = Counter(
"synapse_appservice_api_sent_events",
"Number of events sent to the AS",
["service"]
)

HOUR_IN_MS = 60 * 60 * 1000

Expand Down Expand Up @@ -219,12 +238,15 @@ def push_bulk(self, service, events, txn_id=None):
args={
"access_token": service.hs_token
})
sent_transactions_counter.labels(service.id).inc()
sent_events_counter.labels(service.id).inc(len(events))
defer.returnValue(True)
return
except CodeMessageException as e:
logger.warning("push_bulk to %s received %s", uri, e.code)
except Exception as ex:
logger.warning("push_bulk to %s threw exception %s", uri, ex)
failed_transactions_counter.labels(service.id).inc()
defer.returnValue(False)

def _serialize(self, events):
Expand Down