Consistently use six's iteritems and wrap lazy keys/values in list() if they're not meant to be lazy

[hawkowl]

No description provided.

[erikjohnston]

It feels like this is adding a lot of unnecessary list copying for python2, can we avoid that please?

[erikjohnston]

If we're doing list(foo.keys()) can't we just do list(foo)? Rather than in py2 have the lists be copied twice

[hawkowl]

Good idea, done.

[erikjohnston]

Wouldn't it be nicer to do list(iteritems(...))?

[hawkowl]

That's about twice as slow on Python 2, unfortunately:

~ $ python3 -m timeit "list(globals().items())"
1000000 loops, best of 3: 0.75 usec per loop
~ $ python -m timeit "list(globals().items())"
1000000 loops, best of 3: 0.67 usec per loop
~ $ python -m timeit "list(globals().iteritems())"
1000000 loops, best of 3: 1.02 usec per loop

[erikjohnston]

Well that's fun :/

fixed!

[hawkowl]

@erikjohnston I removed the instances where there was an extra list copy. There is a little bit of overhead with it on items or values, but I think it's negligible enough.

~ $ python -m timeit "list(globals().values())"
1000000 loops, best of 3: 0.298 usec per loop
~ $ python -m timeit "globals().values()"
10000000 loops, best of 3: 0.168 usec per loop
~ $ python -m timeit "list(globals().items())"
1000000 loops, best of 3: 0.665 usec per loop
~ $ python -m timeit "globals().items()"
1000000 loops, best of 3: 0.471 usec per loop