Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use the localpart in the consent uri #3272

Merged
merged 2 commits into from
May 23, 2018
Merged

Use the localpart in the consent uri #3272

merged 2 commits into from
May 23, 2018

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented May 23, 2018

... because it's shorter.

@richvdh
Use the localpart in the consent uri
3ff6f50 
... because it's shorter.
erikjohnston
erikjohnston approved these changes May 23, 2018
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the URI builder allows either a full user_id or localpart?

@richvdh
Copy link
Member Author

richvdh commented May 23, 2018

well, the consent resource allows either. Which may have been a bit of a mistake in retrospect.

@richvdh richvdh merged commit 23aa70c into release-v0.30.0 May 23, 2018
@richvdh richvdh deleted the rav/localpart_in_consent_uri branch May 23, 2018 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @erikjohnston