This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Reject attempts to send event before privacy consent is given #3257
+179
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
richvdh
force-pushed
the
rav/fonx_on_no_consent
branch
from
4761bc6 to
0eff55d
Compare
| membership = builder.content.get("membership", None) | ||
| if membership == Membership.JOIN: | ||
| return self._is_server_notices_room(builder.room_id) | ||
| return succeed(False) |
There was a problem hiding this comment.
Do we not want to exempt AS users?
There was a problem hiding this comment.
Oh, yo do that later. I'm not sure I really get the difference between the checks here and the checks later
There was a problem hiding this comment.
well, it's a difference between "does this action require consent to the privacy policy?" and "does this user need to consent to the privacy policy?".
the distinction means that it is meaningful to call assert_accepted_privacy_policy from the RoomCreationHandler, where we have already established that the action requires consent, but not whether the user needs to do so.
synapse/handlers/message.py
Outdated
| Raises: | ||
| ConsentNotGivenError: if the user has not given consent yet | ||
| """ | ||
| logger.info("Consent for %s", requester.user) |
There was a problem hiding this comment.
Should this really be info?
erikjohnston
approved these changes
May 22, 2018
richvdh
force-pushed
the
rav/fonx_on_no_consent
branch
from
7c682b8 to
f82437f
Compare
Returns an M_CONSENT_NOT_GIVEN error (cf https://github.com/matrix-org/matrix-doc/issues/1252) if consent is not yet given.
richvdh
force-pushed
the
rav/fonx_on_no_consent
branch
from
f82437f to
a5e2941
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns an M_CONSENT_NOT_GIVEN error if consent is not yet given.
Builds on top of #3236.