Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

move handling of auto_join_rooms to RegisterHandler #2996

Merged
merged 2 commits into from
Apr 10, 2018

Conversation

krombel
Copy link
Contributor

@krombel krombel commented Mar 14, 2018

Currently the handling of auto_join_rooms only works when a user
registers itself via public register api. Registrations via
registration_shared_secret and ModuleApi do not work

This auto joins the users in the registration handler which enables
the auto join feature for all 3 registration paths.

This is related to issue #2725

Signed-Off-by: Matthias Kesler [email protected]

Currently the handling of auto_join_rooms only works when a user
registers itself via public register api. Registrations via
registration_shared_secret and ModuleApi do not work

This auto_joins the users in the registration handler which enables
the auto join feature for all 3 registration paths.

This is related to issue matrix-org#2725

Signed-Off-by: Matthias Kesler <[email protected]>
@matrixbot
Copy link
Member

Can one of the admins verify this patch?

1 similar comment
@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@turt2live
Copy link
Member

How does this affect application services trying to register their users? For the sake of not having performance issues, application service users should not be auto-joined anywhere.

@krombel
Copy link
Contributor Author

krombel commented Mar 14, 2018

application services take another path which does not use register() which got modified.
=> This change has no effect on them
You maybe want to compare register and appservice_register

@richvdh
Copy link
Member

richvdh commented Apr 9, 2018

@matrixbot : test this please

@richvdh richvdh merged commit a3599dd into matrix-org:develop Apr 10, 2018
@krombel krombel deleted the allow_auto_join_rooms branch April 10, 2018 08:37
@kojo1984
Copy link

kojo1984 commented Apr 22, 2018

Hi guys,
I'm trying to configure autojoin feature, but with no success. Here's some facts on it:

  1. Changed register.py on both locations (/usr/lib/python2.7/dist-packages/synapse/rest/client/v2_alpha & /usr/lib/python2.7/dist-packages/synapse/handlers)

  2. Can't find test_events.py nowhere.

  3. Added string auto_join_rooms into homeserver.yaml .

  4. I have Matrix/Synapse install with MXISD using WordPress and WP DB for user creation and authentication.

Can you help me on this one?

@krombel
Copy link
Contributor Author

krombel commented Apr 24, 2018

@kojo1984 I do not understand why you do step 1 and 2.
You only need to do step 3 (while having a working auth backend)

I have just tested it (again) and it works.
Just one minor thing to mention: The room has to allow joins for everyone who knows that room link (so not invite only)

For further question I would recommend asking in #synapse-community:matrix.org or #mxisd:kamax.io if that issue is specific to using that backend

@kojo1984
Copy link

@krombel I was just trying everything, because it wasn't working.

Haven't tried to configure the room that allows join to everybody, will do that and get back here.

@richvdh
Copy link
Member

richvdh commented Apr 24, 2018

not here, please. if you have a bug please report it as a separate issue.

neilisfragile added a commit that referenced this pull request Apr 27, 2018
Changes in synapse v0.28.0-rc1 (2018-04-26)
===========================================

Bug Fixes:

* Fix quarantine media admin API and search reindex (PR #3130)
* Fix media admin APIs (PR #3134)

Changes in synapse v0.28.0-rc1 (2018-04-24)
===========================================

Minor performance improvement to federation sending and bug fixes.

(Note: This release does not include state resolutions discussed in matrix live)

Features:

* Add metrics for event processing lag (PR #3090)
* Add metrics for ResponseCache (PR #3092)

Changes:

* Synapse on PyPy (PR #2760) Thanks to @Valodim!
* move handling of auto_join_rooms to RegisterHandler (PR #2996) Thanks to @krombel!
* Improve handling of SRV records for federation connections (PR #3016) Thanks to @silkeh!
* Document the behaviour of ResponseCache (PR #3059)
* Preparation for py3 (PR #3061, #3073, #3074, #3075, #3103, #3104, #3106, #3107, #3109, #3110) Thanks to @NotAFile!
* update prometheus dashboard to use new metric names (PR #3069) Thanks to @krombel!
* use python3-compatible prints (PR #3074) Thanks to @NotAFile!
* Send federation events concurrently (PR #3078)
* Limit concurrent event sends for a room (PR #3079)
* Improve R30 stat definition (PR #3086)
* Send events to ASes concurrently (PR #3088)
* Refactor ResponseCache usage (PR #3093)
* Clarify that SRV may not point to a CNAME (PR #3100) Thanks to @silkeh!
* Use str(e) instead of e.message (PR #3103) Thanks to @NotAFile!
* Use six.itervalues in some places (PR #3106) Thanks to @NotAFile!
* Refactor store.have_events (PR #3117)

Bug Fixes:

* Return 401 for invalid access_token on logout (PR #2938) Thanks to @dklug!
* Return a 404 rather than a 500 on rejoining empty rooms (PR #3080)
* fix federation_domain_whitelist (PR #3099)
* Avoid creating events with huge numbers of prev_events (PR #3113)
* Reject events which have lots of prev_events (PR #3118)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants