This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Implement RoomMemberWorkerHandler #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Mar 13, 2018
richvdh
reviewed
Mar 14, 2018
synapse/replication/http/__init__.py
Outdated
| @@ -15,6 +15,7 @@ | |||
|
|
|||
|
|
|||
| import send_event | |||
| import membership | |||
There was a problem hiding this comment.
from synapse.replication.http import membership, surely?
| from synapse.types import Requester, UserID | ||
| from synapse.util.distributor import user_left_room, user_joined_room | ||
|
|
||
| import logging |
| port=self.config.worker_replication_http_port, | ||
| user_id=target.to_string(), | ||
| room_id=room_id, | ||
| change="join", |
There was a problem hiding this comment.
why "join" and "left", rather than "joined" and "left", or "join" and "leave"?
There was a problem hiding this comment.
Oh, I had it in my head that it was user_join_room. Will change.
| requester = Requester.deserialize(self.store, content["requester"]) | ||
|
|
||
| if requester.user: | ||
| request.authenticated_entity = requester.user.to_string() |
There was a problem hiding this comment.
so, why are we doing this, given we don't appear to ever use request again?
There was a problem hiding this comment.
Its used to log the authenticated entity during Processed request... logging
erikjohnston
force-pushed
the
erikj/implement_member_workre
branch
from
7631189 to
62ad701
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.